Marked as draft, because I didn't run these tests with any implementation yet. They are, however, a direct port of tests I developed for my Quarkus prototype, so they should mostly be fine.

I'll work on running these tests with an implementation next.

Amended the commit with a test for synthetic observers of parameterized types.

The POM now points to the CDI API SNAPSHOT, so this rightfully stays a draft.

Rebased.

As discussed on the CDI call today, we still don't have a way to run this with an implementation, but work is ongoing to run this both with Weld and Quarkus. Once that happens, this PR will be marked as ready for review and assuming no problems are found, merged. More tests need to be added for sure, but those won't block this PR.

I have added a commit that fixes ChangeBeanQualifierTest to demonstrate the issue we described in jakartaee/cdi#564
@graemerocher ^ just to make it clear what we meant :)

Added another commit that fixes all but SyntheticBeanTest where I am not quite sure what the issue is yet.

Ok, added another commit that fixes the last test. With these changes I can get Weld's implementation to pass it.

Moved from draft to standard PR.
I will also give it green light from myself but maybe @Ladicek would like to review it before merging since I made quite a few changes :)

Hi @manovotn, I've pushed a few more commits with some proposed changes, so that:

• the tests pass on ArC;
• multiple combinations of beans.xml present/missing and classes added/not added via @Discovery are tested;
• this still follows the rules for type discovery as we discussed.

If you can let me know how I can test with Weld, I'd be happy to do that.

@Ladicek I am seeing one failing test with Weld. SyntheticObserverOfParameterizedTypeExtension is adding MyService but that class also contains a bean defining annotation and as such is discovered.

The way to execute it with Weld is:

• Check out master branch
• Perform a mvn clean install -DskipTests
• In core/pom.xml, change the value of <cdi.tck-4-0.version> property to 4.0.0-SNAPSHOT
  • This OFC assumes you have CDI TCK built off this PR
• Run mvn clean verify -f jboss-tck-runner/pom.xml

Added one commit to avoid the type discovery duplicate.

I think this is ready to be merged now, because it passes on ArC and Weld. I'll just restructure the commits a little and squash a bunch of them.

Done.